How does this work relate to this PR Matthew is working on: sillsdev/machine.py#285?

@Enkidu93 reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ddaspit).

@ddaspit reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).

src/SIL.Machine/Corpora/UpdateUsfmParserHandler.cs line 468 at r1 (raw file):

                        {
                            // Add the remarks just after the specified chapter,
                            // skipping any alternate and published chapter numbers

Unless I'm missing something, I don't think this will skip \ca and \cp markers.

@Enkidu93 I was unaware of Matthew's PR (sorry that is on me, I forgot to look). It is a little different - this PR keeps support for book level remarks, and allows different remarks per chapter. I've commented on his PR, and am happy to change this PR to match his if my implementation is incorrect (as I couldn't find concrete specs I got to this PR via an hour of iteration and testing).

@pmachapman made 2 comments.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on ddaspit and Enkidu93).

src/SIL.Machine/Corpora/UpdateUsfmParserHandler.cs line 468 at r1 (raw file):

Done. That was a hangover from a previous iteration of this change.

No worries. I think we'll probably want some of the changes from both PRs. We'll want your per-chapter remarks and his support for partial USFM. It's probably best to pick machine or machine.py and make all the changes there and then port. I'll leave it to you and Matthew to figure out what makes the most sense in regard to where and who.

@Enkidu93 reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ddaspit).

We'll want your per-chapter remarks and his support for partial USFM

I have ported the partial USFM support from Matthew's PR.

@pmachapman made 1 comment.
Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on ddaspit and Enkidu93).

@ddaspit reviewed 4 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).

src/SIL.Machine/Corpora/UsfmTokenizer.cs line 43 at r3 (raw file):

            string usfm,
            bool preserveWhitespace = false,
            IReadOnlyList<int> filterTokensByChapter = null

I don't want to mess with UsfmTokenizer. I would prefer to perform the filtering in ParatextProjectTextUpdaterBase.

@pmachapman made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ddaspit).

src/SIL.Machine/Corpora/UsfmTokenizer.cs line 43 at r3 (raw file):

I have moved FilterTokensByChapter to ParatextProjectTextUpdaterBase, and made it internal so the unit tests that require it can used it.

@Enkidu93 reviewed 4 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ddaspit).

@Enkidu93 made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ddaspit).

src/SIL.Machine/Corpora/UsfmTokenizer.cs line 43 at r3 (raw file):

I put a comment in Matthew's PR regarding this. If he refactors there to use a Memory... updater implementation, you'll want to update accordingly.

@ddaspit reviewed 4 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@ddaspit @Enkidu93 I'm requesting a re-review as I have not only bought this branch into sync with @mshannon-sil 's work in machine.py, but I have also done some clean up:

• Refactored DefaultParatextProjectSettings to its own file and made it no longer a nested class
• Did some clean up work in UpdateUsfmParserHandlerTests to use modern C# and NUnit features added in the dotnet 10 upgrade

If you don't like the clean up, or want that in a separate PR, I have kept those changes to their own commits which I can drop/move as you please.

@pmachapman made 2 comments.
Reviewable status: 2 of 13 files reviewed, all discussions resolved (waiting on ddaspit and Enkidu93).

src/SIL.Machine/Corpora/UsfmTokenizer.cs line 43 at r3 (raw file):

Done.

@ddaspit reviewed 11 files and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on Enkidu93).